[E] Frame presets only work on frames that've been saved

Post about any bugs or other issues that you find on AAO.

Moderator: EN - Forum Moderators

Post Reply
User avatar
drvonkitty
Posts: 567
Joined: Sat Apr 14, 2012 12:25 am
Spoken languages: English

[E] Frame presets only work on frames that've been saved

Post by drvonkitty »

OS: Windows 8
Browser: Firefox

The frame presets seem to work well, but I've noticed a bug - if you try to make a brand new frame a preset before the brand new frame has been in a save, it doesn't work. If it's a brand new frame with dialogue and multiple characters, the frame preset will be completely blank. This bug can also be fragmented - i.e., if you add 2 characters to a frame that has been previously saved with 1 character, only the one character will appear.
Image

Image
User avatar
Unas
Admin / Site programmer
Posts: 8850
Joined: Tue Jul 10, 2007 4:43 pm
Gender: Male
Spoken languages: Français, English, Español
Contact:

Re: [E] Frame presets only work on frames that've been saved

Post by Unas »

You mean that any frame that has been created since you last saved the trial is incorrectly loaded as a preset ?

Are you sure about that ?
I mean, not only does it not happen to me, but the editor's current code does not save the initial state of the trial before edition anyway, so there is no way it could know if a frame was created before or since the last save...

Does it happen on all your trials, or one specifically ?
Can you give me a link to a trial where you have the issue ?
The only thing I can think is that, for some reasons (browser bug or extension maybe, but that'd be really weird behaviour), frames created in your browser or trial are appended some property which is not cloneable, or something like that. A property which wouldn't be carried over when the trial is serialised in JSON for saving, so it would work fine afterwards.
Now that I think about it, it might be that something in your browser loads a JS library which extends the Object prototype, and my cloning function currently ignores if properties are own or inherited. If so, the fix should be rather simple.

Can you check if you have some Firefox extensions installed, if disabling one in particular might fix the issue ?
ImageImageImage
If knowledge can create problems, it is not through ignorance that we can solve them.
Si le savoir peut créer des problèmes, ce n'est pas l'ignorance qui les résoudra. ( Isaac Asimov )
User avatar
drvonkitty
Posts: 567
Joined: Sat Apr 14, 2012 12:25 am
Spoken languages: English

Re: [E] Frame presets only work on frames that've been saved

Post by drvonkitty »

Yes, that's what happened.

I have no firefox extensions, but there is one thing that MIGHT be causing it (although I have no clue, admittedly). Whenever I save, refresh, or open the editor, I get this popup: http://i.imgur.com/XprLz4l.png

Here's a link to the trial where it's occurring. I can test it on another trial if need be: http://aceattorney.sparklin.org/editor. ... l_id=69064
Image

Image
User avatar
Unas
Admin / Site programmer
Posts: 8850
Joined: Tue Jul 10, 2007 4:43 pm
Gender: Male
Spoken languages: Français, English, Español
Contact:

Re: [E] Frame presets only work on frames that've been saved

Post by Unas »

drvonkitty wrote:I have no firefox extensions, but there is one thing that MIGHT be causing it (although I have no clue, admittedly). Whenever I save, refresh, or open the editor, I get this popup: http://i.imgur.com/XprLz4l.png
Okay, you definitely have something wrong in your browser. If you're sure you have no extension installed, you should scan your computer for adwares and this kind of things.

This message is saying that Firefox has trouble running jquery code while on AAO... But AAO does not use jquery !
(and anyway, this popup does say that this jquery is loaded as an internal resource, not a URL)

So, yeah, that could very well be the issue here. Not sure though : as far as I know jquery itself would not have this effect. But who knows what else is included along...
ImageImageImage
If knowledge can create problems, it is not through ignorance that we can solve them.
Si le savoir peut créer des problèmes, ce n'est pas l'ignorance qui les résoudra. ( Isaac Asimov )
User avatar
drvonkitty
Posts: 567
Joined: Sat Apr 14, 2012 12:25 am
Spoken languages: English

Re: [E] Frame presets only work on frames that've been saved

Post by drvonkitty »

I've disabled the two extensions I apparently had without my knowledge (one was bing browser which was disabled and the other was skype click to call)...

Anyway, whatever that jquery thing was, it's no longer happening. However, the issue with the presets remains, and it also happens on another trial.
Image

Image
User avatar
Tiagofvarela
Posts: 357
Joined: Thu Jun 26, 2014 7:16 pm
Gender: Male
Spoken languages: English, Portuguese
Location: Portugal

Re: [E] Frame presets only work on frames that've been saved

Post by Tiagofvarela »

Joining in here.

OS: Windows Vista (And the same applies to 10 and 8, I'm pretty sure).
Browser: Firefox 39.
Trial: http://aceattorney.sparklin.org/editor. ... l_id=77479 (Although I think it's the same on any - not confirmed)
Extensions: Apparently, everything is disabled...? Although I have plenty of plugins? I don't know how this works.


None of this applies if I save the trial after making the frame. The presets work as intended after that point.
When I create a new frame, add some stuff to it (backgrounds, characters, etc.), if I attempt to save it as a preset, before saving the trial itself, the whole thing will not be saved. Typically only the text remains, but it's kind of random.
I have an image that will show a very curious detail:
http://i.imgur.com/NGYo7XL.png?1
The frame below is the one I set as a preset.
The frame above is the frame I pasted after being made a preset.

*I made the frame you can see below.
*A while later I came back and changed the apostrophe (so it would be before the 200 pause).
*After that I saved it as a preset and pasted it directly above.
*The result is what you can see. The pasted frame is different from the one I copied it from.

Very Curious:
For some reason, the pasted text is the same as it was when I initially wrote it (Notice that the apostrophe reverted to before I changed it). The copied frame was originally like that, but then I edited and only saved it as a preset after editing.

Extra Testing:
I may be onto something here. After the above issue occurred, I tried to test the circumstances surrounding it, but I'm sure it has to do with the scene editor, somehow.
Test One:
http://i.imgur.com/13ClNUF.png?1 - I made a new frame (middle one - 1538)
http://i.imgur.com/CfOniEk.png?1 - I set the background.
http://i.imgur.com/eGi5j4q.png?1 - I changed the text.
http://i.imgur.com/43UGlCC.png?1 - I saved as a preset and pasted it above.

Test Two:
http://i.imgur.com/wxJ9OiC.png?1 - I reloaded and made a new frame.
http://i.imgur.com/pNw1xhx.png?1 - I set a bunch of stuff.
http://i.imgur.com/nt0EIDY.png?1 - I set the background.
http://i.imgur.com/vpCAVGa.png?1 - I changed the text, saved as a preset and pasted it above.
http://i.imgur.com/DnAHp3F.png - I deleted the pasted frame (1539). I removed the background and character from the original one. Saved as a preset again. Pasted it above again.
For some reason, after deleting the background and the character, it didn't save that change (deletion) but saved me adding the background, Judge and editing the text, which it hadn't last time.

Conjecture:
Maybe, the preset only works up until I do a certain something. If we assume this was the order of events:
*Created frame 1531
*Changed typing speed.
*Set the music.
*Set Apollo as talker.
*Wrote the text (with the wrong apostrophe)
*Set background and character.
*Set the 3000 timer.
*Fixed the text.
*Saved as a preset.

Perhaps, the preset only saves the stuff up until I go to the screen editor (or take some other action and the preset only works up until that point). This would explain why only seemingly random stuff got saved into the preset, and most importantly, why the text reverted to how it was initially (before I set the background and fixed the apostrophe).

After further testing, I can confirm that any changes made after I set the background and character are forgotten. For example, if I set the typing speed to 1.6, then added a background and character, and then set the typing speed to 1.4; when I save the preset and paste it somewhere, the typing speed will be 1.6 and there will be no background or character.
A Laggy Turnabout ★
A Batty Turnabout ★
A Tricky Turnabout ★
Upcoming: A Worldly Turnabout, A Courtly Turnabout, A Clumsy Turnabout, A Needy Turnabout
User avatar
Enthalpy
Community Manager
Posts: 5169
Joined: Wed Jan 04, 2012 4:40 am
Gender: Male
Spoken languages: English, limited Spanish

Re: [E] Frame presets only work on frames that've been saved

Post by Enthalpy »

I'm seeing a similar bug on my El Capitan. I create a new frame, set a place and a character, save it as a preset, try to create a frame from it, and end up generating a blank frame. I'll investigate this - hopefully I can solve the rest of this strangeness in the process!

EDIT: For those whom it concerns: Cause of the bug identified. Here's hoping I can fix it soon!

Basically, Unas's statement that "the editor's current code does not save the initial state of the trial before edition anyway" is incorrect. It's saved into a variable called frame_data when the row is built... the same row that is used to make the preset.
[D]isordered speech is not so much injury to the lips that give it forth, as to the disproportion and incoherence of things in themselves, so negligently expressed. ~ Ben Jonson
User avatar
Enthalpy
Community Manager
Posts: 5169
Joined: Wed Jan 04, 2012 4:40 am
Gender: Male
Spoken languages: English, limited Spanish

Re: [E] Frame presets only work on frames that've been saved

Post by Enthalpy »

My pull was accepted, so this bug should be fixed on the next AAO update!
[D]isordered speech is not so much injury to the lips that give it forth, as to the disproportion and incoherence of things in themselves, so negligently expressed. ~ Ben Jonson
Post Reply