Moderator: EN - Forum Moderators
Unas wrote:Well, forgive me if I'm a little blunt, but the main issue with your PRs is that it looks like you never test any of your changes, and I don't really have time to fetch them and test them myself.
You see, the correct way to go with things is :
- A contributor makes a change on a new branch of his fork.
- That contributor tests his change to make sure it's working.
- That contributor opens a pull request. (update and re-test if necessary)
- The pull request is merged onto develop.
- When making a new release from develop, I test the new version to make sure the changes still work and did not break anything else.
In Enthalpy's case, I know I can usually trust him about testing changes : he has a local git clone, he uses static testing, and just made a fix on mocked testing precisely to have it work on his machine (which apparently has stricter settings than mine).
If I'm confident something has been reasonably tested, I can merge it.
In your case, the changes are usually not tested. Enth and I are repeatedly asked you "did you test that change ?" and you never ever answered it. Plus, it's pretty clear that you are still not using git, always editing using the web interface (against my recommendations) - which supports the idea that you are not testing anything on your machine.
That's why I can't trust your code : I'm pretty sure it wasn't tested, and I would have to fetch your fork and test it myself before merging. That's a lot more time than just clicking the merge button.
You have to understand that my recommendations on how to contribute are here for a reason. Using git for development on AAO is not optional, neither is testing your changes locally before pushing.
That's the whole reason I created two new testing environments (static testing and mocked testing) before going public : I know that a fully integrated environment is hard to setup for a newbie developer, so I've given you simpler ways to test changes.
I made an effort to make testing simpler for other contributors (as far as I'm concerned, I've had a fully integrated install set up on all of my computers for ages, so I really didn't need that), now it's your turn to make an effort and actually test your stuff.
You can't contribute by just throwing in code lines here and there and expect the others to fix it : to make useful contributions, you first need to make sure that they work.
kwando1313 wrote:Speaking of Enthalpy's change to the mocked_install... Will that be merged in soon? (Mostly because I actually want to start doing some coding for AAO again. xP)
AceAttorneyMaster111 wrote:I've tried downloading the latest stable version of Git 300 gazillion times. I've also tried downloading the mocked install 300 gazillion times, even before Issue 123. It never works on my computer.
Users browsing this forum: No registered users and 1 guest