Please integrate mobile fixes PR posted a while back

If you wish to contribute to the Ace Attorney Online Game Creation Engine open source project, or just know more about the way it is developed, this is the place.

Moderator: EN - Forum Moderators

Post Reply
User avatar
roylaza
Posts: 5
Joined: Sat Nov 24, 2012 4:25 am
Gender: Male
Spoken languages: English

Please integrate mobile fixes PR posted a while back

Post by roylaza »

Hello everyone

I was wondering if there are plans to integrate this PR posted a while back which fixes the layout for mobile users:

https://bitbucket.org/AceAttorneyOnline ... quests/103

Thank you and sorry if posted in the wrong place
User avatar
TimeAxis
Posts: 394
Joined: Fri Jan 01, 2021 8:27 pm
Spoken languages: English
Contact:

Re: Please integrate mobile fixes PR posted a while back

Post by TimeAxis »

There aren't currently any active code reviewers, so PRs have been left alone for a while, including one of mine that fixes a minor Expression Engine bug. You could try your luck at e-mailing Unas if you want. Otherwise, we pretty much just have to wait for one of the devs to have enough free time and feel like doing it.
Image
Question Arcs (Threads Coming Eventually)
ImageImageImageImage
Gaiden Episodes
Champion of Turnabouts ★
HALLOWEEN HERO
Other
Phoenix Wright: Ace Attornauts
The Curious Case of the Phantom Limousine (Coming Eventually)
The Imposter's Turnabout (Coming Maybe)
User avatar
roylaza
Posts: 5
Joined: Sat Nov 24, 2012 4:25 am
Gender: Male
Spoken languages: English

Re: Please integrate mobile fixes PR posted a while back

Post by roylaza »

Thanks for the reply.

I think in the meantime I'll try to fix some of the issues with a single css file and find a way to inject it to the client, maybe via a Chrome extension, if I'm successful I'll post the file with instructions for others to use
User avatar
Enthalpy
Community Manager
Posts: 5175
Joined: Wed Jan 04, 2012 4:40 am
Gender: Male
Spoken languages: English, limited Spanish

Re: Please integrate mobile fixes PR posted a while back

Post by Enthalpy »

Thanks for your patience. Things have been crazy for me lately, but are at long last calming down.

I'm hoping to be able to review the PR tomorrow. Thanks for this!
[D]isordered speech is not so much injury to the lips that give it forth, as to the disproportion and incoherence of things in themselves, so negligently expressed. ~ Ben Jonson
User avatar
roylaza
Posts: 5
Joined: Sat Nov 24, 2012 4:25 am
Gender: Male
Spoken languages: English

Re: Please integrate mobile fixes PR posted a while back

Post by roylaza »

Enthalpy wrote: Mon Apr 03, 2023 4:58 am Thanks for your patience. Things have been crazy for me lately, but are at long last calming down.

I'm hoping to be able to review the PR tomorrow. Thanks for this!
That's great news Enthalpy, in the meantime I posted a client-side fix for others to use but the fix in this PR is a lot more robust
Thank you very much
Post Reply